Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: document flow for supporting type generation #41464

Closed
wants to merge 1 commit into from
Closed

doc: document flow for supporting type generation #41464

wants to merge 1 commit into from

Conversation

mhdawson
Copy link
Member

Refs: nodejs/next-10#104

Add initial doc to capture how the project supports
the flow for types generation. Based on discussions
from the Next-10 mini-summit that included project
members and members of the Definitely Typed team.

Will need to be updated as we improve the flow and
resulting json but captures the current flow and
approach and will give us the place where we can
update as things change.

Signed-off-by: Michael Dawson mdawson@devrus.com

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 10, 2022
@mhdawson mhdawson mentioned this pull request Jan 10, 2022
Closed
5 tasks
VoltrexKeyva
VoltrexKeyva reviewed Jan 11, 2022
View reviewed changes
doc/guides/maintaining-types-for-nodejs.md Outdated Show resolved Hide resolved
doc/guides/maintaining-types-for-nodejs.md Outdated Show resolved Hide resolved
doc/guides/maintaining-types-for-nodejs.md Outdated Show resolved Hide resolved
doc/guides/maintaining-types-for-nodejs.md Outdated Show resolved Hide resolved
doc/guides/maintaining-types-for-nodejs.md Outdated Show resolved Hide resolved
doc/guides/maintaining-types-for-nodejs.md Outdated Show resolved Hide resolved
@mhdawson
Copy link
Member Author

@HarshithaKP, @VoltrexMaster thanks for the fixes, all incorporated.

@mhdawson
Copy link
Member Author

@targos, @bnb, @legendecas since you were at the summit could you review/approve if this captures what was agreed?

targos
targos approved these changes Jan 19, 2022
View reviewed changes
doc/guides/maintaining-types-for-nodejs.md Outdated Show resolved Hide resolved
Mesteery
Mesteery reviewed Jan 19, 2022
View reviewed changes
Copy link
Contributor

@Mesteery Mesteery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be moved to doc/contributing instead of doc/guides?

doc/guides/maintaining-types-for-nodejs.md Outdated Show resolved Hide resolved
doc/guides/maintaining-types-for-nodejs.md Outdated Show resolved Hide resolved
@mhdawson
Copy link
Member Author

@Mesteery suggestions incorporated.

@mhdawson
doc: document flow for supporting type generation
8016c72 
Refs: nodejs/next-10#104

Add initial doc to capture how the project supports
the flow for types generation. Based on discussions
from the Next-10 mini-summit that included project
members and members of the Definitely Typed team.

Will need to be updated as we improve the flow and
resulting json but captures the current flow and
approach and will give us the place where we can
update as things change.

Signed-off-by: Michael Dawson <mdawson@devrus.com>
@mhdawson
Copy link
Member Author

@Mesteery rebased so doc is in right place now.

mhdawson added a commit that referenced this pull request Jan 25, 2022
@mhdawson
doc: document flow for supporting type generation
670dbba 
Refs: nodejs/next-10#104

Add initial doc to capture how the project supports
the flow for types generation. Based on discussions
from the Next-10 mini-summit that included project
members and members of the Definitely Typed team.

Will need to be updated as we improve the flow and
resulting json but captures the current flow and
approach and will give us the place where we can
update as things change.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41464
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@mhdawson
Copy link
Member Author

Landed in 670dbba

@mhdawson mhdawson closed this Jan 25, 2022
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@mhdawson @Linkgoron
doc: document flow for supporting type generation
9454f18 
Refs: nodejs/next-10#104

Add initial doc to capture how the project supports
the flow for types generation. Based on discussions
from the Next-10 mini-summit that included project
members and members of the Definitely Typed team.

Will need to be updated as we improve the flow and
resulting json but captures the current flow and
approach and will give us the place where we can
update as things change.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: nodejs#41464
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
@mhdawson @ruyadorno
doc: document flow for supporting type generation
0ee468d 
Refs: nodejs/next-10#104

Add initial doc to capture how the project supports
the flow for types generation. Based on discussions
from the Next-10 mini-summit that included project
members and members of the Definitely Typed team.

Will need to be updated as we improve the flow and
resulting json but captures the current flow and
approach and will give us the place where we can
update as things change.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41464
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@mhdawson @danielleadams
doc: document flow for supporting type generation
dfbe567 
Refs: nodejs/next-10#104

Add initial doc to capture how the project supports
the flow for types generation. Based on discussions
from the Next-10 mini-summit that included project
members and members of the Definitely Typed team.

Will need to be updated as we improve the flow and
resulting json but captures the current flow and
approach and will give us the place where we can
update as things change.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41464
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@danielleadams danielleadams mentioned this pull request Mar 3, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@mhdawson @danielleadams
doc: document flow for supporting type generation
36ccb62 
Refs: nodejs/next-10#104

Add initial doc to capture how the project supports
the flow for types generation. Based on discussions
from the Next-10 mini-summit that included project
members and members of the Definitely Typed team.

Will need to be updated as we improve the flow and
resulting json but captures the current flow and
approach and will give us the place where we can
update as things change.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41464
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@mhdawson @danielleadams
doc: document flow for supporting type generation
b63fb0f 
Refs: nodejs/next-10#104

Add initial doc to capture how the project supports
the flow for types generation. Based on discussions
from the Next-10 mini-summit that included project
members and members of the Definitely Typed team.

Will need to be updated as we improve the flow and
resulting json but captures the current flow and
approach and will give us the place where we can
update as things change.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41464
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarshithaKP HarshithaKP HarshithaKP left review comments

@Mesteery Mesteery Mesteery left review comments

@VoltrexKeyva VoltrexKeyva VoltrexKeyva left review comments

@jasnell jasnell jasnell approved these changes

@targos targos targos approved these changes

@legendecas legendecas legendecas approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mhdawson @jasnell @targos @legendecas @HarshithaKP @Mesteery @VoltrexKeyva @nodejs-github-bot